Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for image-viewer chapter #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes for image-viewer chapter #193

wants to merge 1 commit into from

Conversation

thomasgervaise-pix4d
Copy link

  • Platform was not suffixed to elements belonging to to Qt.labs.platform, causing ReferenceError at runtime
  • FileDialog's interface specifies that url is the correct member to be used to retrieve an image URL, current code causes error
  • The image showing the about dialog doesn't match the code of the about dialog provided. Set modal to true and aligned center with the parent.

@thomasgervaise-pix4d
Fixes for image-viewer chapter
df95c83 
- Platform was not suffixed to elements belonging to to Qt.labs.platform, causing ReferenceError at runtime
- FileDialog's interface specifies that url is the correct member to be used to retrieve an image URL, current code causes error
- The image showing the about dialog doesn't match the code of the about dialog provided. Set modal to true and aligned center with the parent.
@thomasgervaise-pix4d thomasgervaise-pix4d mentioned this pull request Jun 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomasgervaise-pix4d